Make traccc::alpaka executables work in pure C++ #832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Non-technical point, but GitHub is failing to pick up both @CrossR and your own contribution to this due to I guess your email being unknown to GitHub, and Ryan not being mentioned as a co-author. If Ryan is responsible for part of this code I'd suggest adding a co-authorship trailer to the end of the commit:
|
|
OK, do I need a new commit now? or can that be done on the merge commit? |
|
I can try doing it via the merge commit. 👍 |
stephenswat
reviewed
Jan 30, 2025
stephenswat
reviewed
Jan 30, 2025
stephenswat
approved these changes
Jan 31, 2025
krasznaa
requested changes
Jan 31, 2025
device/alpaka/include/traccc/alpaka/seeding/track_params_estimation.hpp
Outdated
Show resolved
Hide resolved
krasznaa
requested changes
Feb 2, 2025
device/alpaka/include/traccc/alpaka/seeding/track_params_estimation.hpp
Outdated
Show resolved
Hide resolved
device/alpaka/include/traccc/alpaka/seeding/track_params_estimation.hpp
Outdated
Show resolved
Hide resolved
krasznaa
approved these changes
Feb 4, 2025
krasznaa
approved these changes
Feb 6, 2025
added 13 commits
February 6, 2025 15:01
… utils. Built on work by Ryan Cross
krasznaa
force-pushed
the
alpaka_separation
branch
from
b8b5ceb to
427d493
Compare
|
noyaboy
pushed a commit
to noyaboy/traccc
that referenced
this pull request
May 16, 2025
* Make traccc::alpaka executables work in pure C++: move device code to utils. Built on work by Ryan Cross * Fix formatting * Fix choice of CPU backend, move to alpaka device_copy in track_params_estimation * Fix formatting * Remove variable only used for one file * Move to CDNA warp size for AMD * Fix ifdef logic for SYCL * Formatting * Move back to vecmem::copy * Move back to vecmem::copy * Move tag logic to device_tag.hpp, make get_device_info return a string * Remove position-independent executable logic: not needed now that this is pure C++ * Fix copy-paste error in alpaka cuda device_memory_resource --------- Co-authored-by: Stewart Martin-Haugh stewart.martin-haugh@stfc.ac.uk <smh@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move device code to utils. Built on work by @CrossR (currently in a private branch with other changes for track fitting).